For a relationship that has gone on that long...not to mention, she sems to make him very happy...I think they should.
And don't get me wrong, I like Princess Di, but I think Charles should have a chance at happiness as well. Afterall, he's not getting any younger, and pretty soon his own children will have their own family to take care of, and he needs someone to take care of him when he becomes king.